[MIRROR] Makes dart insert projectile var modification code slightly better #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…slightly better [MDB IGNORE] (#25209) * [NO GBP] Makes dart insert projectile var modification code slightly better (#79886) ## About The Pull Request Ninja told me that I shouldn't use a signal to get the variable modifiers that a dart insert applies to its projectile. When I asked if using a callback passed as an initialization param was okay, Potato told me it was better. ## Why It's Good For The Game Less code smells. ## Changelog No player-facing changes. * [NO GBP] Makes dart insert projectile var modification code slightly better --------- Co-authored-by: Y0SH1M4S73R <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Feb 7, 2024
* Fixes some irregularities in heretic research tree (#81302) ## About The Pull Request Once again, I fix a few errors in the heretic research tree: - the lunar path no longer unlocks its sidepaths and reroll one research before every other path, and this side knowledge in turn no longer unlocks the earlier knowledge of the moon path - blood siphon no longer unlocks apetra vulnera in addition to its proper main path nodes - ashen ritual now unlocks the nightwatcher's rebirth, instead of unlocking the lonely ritual - lunar blade upgrade is no longer cheaper than those of the other paths - burglar's finesse now costs 1 point like other knowledge of its level ## Why It's Good For The Game Heretic tree should not be irregular for no reason, I think. If any of those quirks were intentional, please let me know. ## Changelog :cl: fix: smoothed out a few asymmetries in the heretic research tree /:cl: * Fixes some irregularities in heretic research tree --------- Co-authored-by: ViktorKoL <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25209
Original PR: tgstation/tgstation#79886
About The Pull Request
Ninja told me that I shouldn't use a signal to get the variable modifiers that a dart insert applies to its projectile. When I asked if using a callback passed as an initialization param was okay, Potato told me it was better.
Why It's Good For The Game
Less code smells.
Changelog
No player-facing changes.